ljharb/qs

Arrays parsed incorrectly

Open

#288 创建于 2018年11月27日

在 GitHub 查看
 (3 评论) (3 反应) (0 负责人)JavaScript (8,015 star) (744 fork)batch import
feature requesthelp wantedparse

描述

Hi, I have this object:

const filter = {
  3: [{ name: 'Test', id: 50753 }, { name: 'Test2', id: 48464 }],
  6: ['2018-11-01', '2018-11-02']
}

I call stringify and parse

const stringifyQuery = Qs.stringify(filter, { arrayFormat: 'brackets' })
const parseQuery = Qs.parse(stringifyQuery, { arrayLimit: 0 })

Result parse: Key '3' contains only 1 element instead of 2. And this element contains the merged keys name, id:

3: Array(1)
  0:
    id: (2) ["50753", "48464"]
    name: (2) ["Test", "Test2"]

I expect:

3: Array(2)
  0: {name: "Test", id: 50753}
  1: {name: "Test2", id: 48464}

Please help me https://codepen.io/anon/pen/rQrqXx

贡献者指南

技术栈
javascriptnodejs
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptunderstanding of querystring parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the parsing logic in the qs library, specifically the handling of arrayLimit:0 and arrayFormat:'brackets'. Look at the source code in lib/parse.js to understand how arrays with mixed types (objects and primitives) are parsed. The issue provides a clear reproduction case. Check if there are any existing comments or PRs addressing this. The fix likely requires adjusting the parser to handle arrayLimit:0 correctly when arrayFormat is 'brackets'.
Arrays parsed incorrectly · ljharb/qs#288 | Good First Issue