livepeer/go-livepeer

running `-nvidia=0` with `-testTranscoder=false` results in an O with no capabilities

开放

#2,450 创建于 2022年6月7日

 (1 条评论) (0 个反应) (1 位负责人)Go (223 个派生)auto 404
area: orchestrator QoLgood first issuehacktoberfest

仓库指标

星标
 (583 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Once upon a time you had to run -testTranscoder false if you were going to use Nvidia transcoding on Windows. That appears to have been fixed, hooray!

But I did it anyway:

./livepeer.exe -orchestrator true -transcoder true \
  -network offchain -serviceAddr 192.168.0.49:8935 \
  -nvidia 0 -v 9 -testTranscoder false

and it results in a completely useless O: it reports that it has zero capabilities to do anything whatsoever; Bs will always pass it over during the discovery process. No obvious reason for such a thing to be running at all — I guess it could make reward calls or something.

Minimally we should print a log line for this or crash entirely. But perhaps it's time to remove the testTranscoder flag entirely if it's not useful anymore?

贡献者指南