linebender/druid

Mutating setters on druid_shell::Window should have `set_` names.

Open

#777 创建于 2020年3月30日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Rust (9,091 star) (567 fork)batch import
help wantedshell

描述

At least including set_resizeable, and set_show_titlebar, although the latter name isn't great. I might change it to something like titlebar_is_visible and set_titlebar_is_visible or something?

Hmm must not have noticed this, but these should be called set_.

Originally posted by @cmyr in https://github.com/xi-editor/druid/pull/773

贡献者指南

技术栈
rust
领域
desktop
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Rename mutating setters in druid shell::Window to have `set ` prefix. Specifically, `set resizeable` and `set show titlebar` (or consider renaming `show titlebar` to `titlebar is visible`). Review the discussion in PR #773 for context. The changes are localized to the druid shell crate, likely in the Window struct implementation.
Mutating setters on druid_shell::Window should have `set_` names. · linebender/druid#777 | Good First Issue