line/armeria

Consider to remove sorting at MeterIdPrefix

已关闭

#2,150 创建于 2019年10月3日

 (10 条评论) (0 个反应) (0 位负责人)Java (863 个派生)batch import
good first issueperformance

仓库指标

星标
 (4,552 个星标)
PR 合并指标
 (平均合并 5天 12小时) (30 天内合并 42 个 PR)

描述

Currently, we sort the micrometer tags at MeterIdPrefix to create Meter ID stably. https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/metric/MeterIdPrefix.java#L95-L101

Since I saw this stacktrace from our service’s flamegraph, I would like to consider whether it is avoidable or not. Since it doesn’t have many samples, we can be ignored but because it is not optimal, it would be happy if we can avoid this sort.

贡献者指南