libp2p/py-libp2p

Medley of `pubsub` improvements

开放

#283 创建于 2019年9月5日

 (6 条评论) (1 个反应) (0 位负责人)Python (238 个派生)auto 404
help wanted

仓库指标

星标
 (618 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Leaving this here while I'm reviewing the current pubsub packages...

  1. Don't serialize message sends, eg: https://github.com/libp2p/py-libp2p/blob/master/libp2p/pubsub/gossipsub.py#L172-L177 Happens here and in floodsub as well -- this is a great place to use asyncio.gather

  2. "separate policy from mechanism" -- in the same place, we defer to the particular router to decide who to send new msgs to... and then do the sending in the router itself. as far as i can tell, we can pull out the sending part into the Pubsub class, relying on the router for what should be its only job -- determining peers for some action

贡献者指南