libp2p/jvm-libp2p

Test coverage of MultiplexHandler/Channel

开放

#27 创建于 2019年7月12日

 (2 条评论) (0 个反应) (0 位负责人)Kotlin (85 个派生)auto 404
good first issue

仓库指标

星标
 (359 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Cover the MultiplexHandler/Channel classes with unit tests. These are pretty central and non-primitive classes so they should be tested well. Primary attention should paid to closing child channels, so once the channel is created it must be finally closed. Child channels shouldn't leak. There are following close circumstances:

  • parent channel is closed
  • remote peer sends RESET signal
  • local peer sends RESET (on channel.close() invoked)
  • remote and local peers sends CLOSE (on channel.disconnect())

Child channels may be created with MultiplexHandler.createStream() asynchronously from any thread and prior to the parent channel is activated. Those cases should also be considered.

贡献者指南