leon-ai/leon

improve the Isitdown module

Open

#25 创建于 2019年2月18日

在 GitHub 查看
 (20 评论) (0 反应) (0 负责人)TypeScript (14,041 star) (1,186 fork)batch import
good first issueimprovementskill

描述

Expected Behavior

Be able to query the status of some website without the fully qualified domain name.

Actual Behavior

Currently a query like this fails is gitub up ? I should ask is github.com up ?

Proposal

May be list some of the most popular websites and treat them with special query as I made just before

贡献者指南

技术栈
typescriptnodejs
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
TypeScript basicsFamiliarity with the isitdown module
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Examine the isitdown module's query handling logic in the codebase, likely in a file like src/modules/isitdown. Identify where the input query is parsed and how the domain is extracted. Review the 20 comments on the issue for any suggested approaches or concerns. Implement a mapping of common website names (without TLD) to their full domains, such as 'github' > 'github.com', and modify the parsing to first check this mapping before treating the input as a full domain. Look at existing tests for the module to ensure the change is correctly implemented.