leecade/react-native-swiper

v1.5.0 code-review request

Open

#243 创建于 2016年9月22日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (10,334 star) (2,346 fork)batch import
help wanted

描述

ref: https://github.com/leecade/react-native-swiper#changelogs

There are two Major changes:

  1. Adjust project structure, publish with src file, use watch-copy script and relative dependencies for improve develop workflow

    "dependencies": {
    "react-native-swiper": "../"
},

  2. ES6 syntex and standard[https://github.com/feross/standard] code style

Please help for more tests and code review, then release 1.5.0, thanks a lot.

@rajkissu @sunnylqm @tasiyo7333 @getnashty

贡献者指南

技术栈
javascriptreact
领域
mobile
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React Native basicsES6 syntaxCode review experience
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the project structure changes and ES6 refactoring in the `src` directory. Compare with the previous structure. Check for adherence to standard code style (feross/standard). Look for any missing tests or potential regressions. The maintainer may have additional comments in the linked changelogs.
v1.5.0 code-review request · leecade/react-native-swiper#243 | Good First Issue