lbryio/lbry-sdk

Add type to supports data

Open

#919 创建于 2017年9月22日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Python (7,220 star) (500 fork)batch import
area: jsonrpchelp wantedlevel: 1type: improvement

描述

The Issue

Currently, when you list claim information (claim_list_mine/claim_show/resolve/claim_list) that shows supports, you can't tell if it's a classical support or a tip. We should add a type attribute to each support. If someone sends a tip to themselves, it's treated the same way as a classical support, so not sure which way it needs to be captured.

This will be an important field to report of off for search results and have available in the block explorer.

Expected behaviour

Support should show if it's a tip or not

Actual behaviour

Can't tell if support is a tip or classic support

贡献者指南

技术栈
python
领域
blockchainbackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Basic PythonUnderstanding of LBRY claim data model
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Review the current support data structure in the LBRY SDK, likely in files such as `lbry/schema/claim.py` or similar. Check existing comments in issue #919 for any proposed approaches. Determine where support objects are created and how the 'type' field should be integrated. Update serialization and deserialization to include the new field, ensuring backward compatibility.