lbryio/lbry-desktop

Add an option to build the the app using the elctron installed on the system

Open

#7,117 创建于 2021年9月17日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)JavaScript (3,596 star) (412 fork)batch import
help wantediceboxlevel: 3type: new feature

描述

Is your feature request related to a problem? Please describe. I use ppc64le architecture and vanilla electron is not compatible... there are patched versions (of electron) available on some GNU/Linux distros like Void-ppc.

Describe the solution you'd like Basically adding an option to the build system that uses the distro's electron

Describe alternatives you've considered Use a precompiled version of electron on ppc64le?

贡献者指南

技术栈
javascriptelectron
领域
desktopbuild system
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Node.jsElectronBuild system (e.g., electron builder)
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the existing build configuration in package.json and the electron builder config. Research how other Electron apps implement a fallback to system electron (e.g., via environment variable `ELECTRON OVERRIDE DIST` or similar). Check the comment from the author for additional context. The solution likely involves modifying the build script to allow skipping the download of prebuilt Electron and instead use the system installed Electron binary.