lbryio/lbry-desktop

Full screen (f11) does not work for games (PDFs and images also)

Open

#2,267 创建于 2019年2月5日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (3,596 star) (412 fork)batch import
area: uxhelp wantedlevel: 2

描述

The Issue

When playing Unity games the app will not get in the full-screen mode (F11).

@tzarebczan mentioned that it also doesn't work for PDFs and images.

Could be related to: https://github.com/lbryio/lbry-desktop/issues/1815

Steps to Reproduce

Load a game from lbry://OpenSourceGames and try to get into full screen.

System Configuration

  • LBRY Daemon version: 0.30.4
  • LBRY App version: 0.28.0-rc.4
  • LBRY Installation ID:
  • Operating system: win 10

贡献者指南

技术栈
javascriptreact
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
familiarity with Electronunderstanding of fullscreen API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
The issue reports that F11 fullscreen doesn't work for games, PDFs, and images in the LBRY desktop app. Start by examining the Electron fullscreen implementation in the app, focusing on how webviews or browser windows handle fullscreen events. Check the referenced issue #1815 for possibly related context. Reproduce the bug using the steps provided (a Unity game from LBRY). Look at the Electron documentation for the fullscreen API and consider if the issue is related to the webview not receiving the F11 event or the app not supporting fullscreen for certain content types. There are no comments or PRs to guide, so initial investigation is needed.