lbryio/lbry-desktop

Flow type errors

Open

#2,024 创建于 2018年10月10日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (3,596 star) (412 fork)batch import
hacktoberfesthelp wanted

描述

We are currently trying to use Flow in every file. We have been slowly making progress but there are still a lot of errors.

If you open a PR with some Flow error fixes (or anything else) we will send you some LBC as appreciation!

Some of the biggest offenders right now are in pages/file/view.jsx and anything with subscriptions.

To see all of the errors you can run ./node_modules/.bin/flow --color always

贡献者指南

技术栈
javascriptreact
领域
developer experience
议题类型
chore
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of FlowNode.js and npm installed
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Start by running `./node modules/.bin/flow color always` in the project root to list all current errors. Focus on files like `pages/file/view.jsx` and areas related to subscriptions, as they are mentioned as major offenders. Fix simple type annotations first, using existing type definitions in the codebase as a reference. The maintainer offers LBC tokens as appreciation for contributions.