launchbadge/sqlx

Log queries including bind arguments and execution time

Open

#162 创建于 2020年3月26日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)Rust (13,916 star) (1,307 fork)batch import
enhancementhelp wanted

描述

TRACE sqlx::query > SELECT …, elapsed: 0.04ms

    SELECT foo, bar, baz
    FROM this_table_over_here
    WHERE foo = $1 AND bar = $2
    ORDER BY baz

    $1 = 50
    $2 = 694

TRACE sqlx::query > INSERT INTO table_name …, elapsed: 12.04ms

Log format is very "let's figure out what we think looks best". Use log. We should new line + indent like error stack traces for the query body. Not sure how to nicely show the bind arguments.

贡献者指南

技术栈
rust
领域
backenddatabaseobservability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rust programmingUnderstanding of sqlx query executionFamiliarity with the `log` crate
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the current trace logging in sqlx, likely in `sqlx core/src/query.rs` or similar, to understand where the elapsed time and bind arguments are available. Determine how to format the output with newlines and indentation for the query body and how to display bind arguments. Review any prior discussion or linked PRs in the issue for design preferences. Implement using the `log::trace!` macro and ensure the format is consistent with other sqlx logs.
Log queries including bind arguments and execution time · launchbadge/sqlx#162 | Good First Issue