laravel/pint

Asymmetric Visibility Issue

Open

#383 创建于 2025年7月18日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)PHP (3,127 star) (189 fork)user submission
help wanted

描述

Pint Version

1.24.0

PHP Version

8.4

Description

There seems to be a bug with how asymmetric visibility is handled. The following class properties are fine:

  • public private(set) int $concurrency;
  • private int $concurrency;

However if I try to use the abbreviated form private(set) int $concurrency; as specified in the RFC then I get the error Cannot access offset of type null on SplFixedArray

Steps To Reproduce

Set a class property like private(set) int $propertyName and then run pint on the file.

贡献者指南

技术栈
php
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PHP 8.4asymmetric visibility syntax
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the bug by examining how Pint parses property modifiers, specifically the handling of `private(set)` without explicit visibility. Look at the grammar file or lexer (likely in `src/` directory) that tokenizes and parses property declarations. The single comment on the issue may provide additional clues. Test with the provided reproduction case and ensure the fix aligns with the PHP RFC on asymmetric visibility.