lanl/singularity-eos

Should we remove forwarding references from PTE solvers?

开放

#438 创建于 2024年11月29日

 (4 条评论) (0 个反应) (0 位负责人)C++ (21 个派生)auto 404
bugclean-updiscussionhelp wantedinterfacequestion

仓库指标

星标
 (36 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

The segfault on HIP was caused by an access-out-of-scope error caused by passing pointers by reference into the PTE solvers. See #437 . Perhaps we should consider removing the forwarding references and pass only by value into the PTE solvers (with the exception of PTE Solver Base, which requires pass-by-reference as it is used as the first part of the derived class constructors).

Ping @jhp-lanl @jdolence @dholladay00 @mauneyc-LANL and @rbberger for feedback

贡献者指南