lanl/singularity-eos

Inconsistent naming conventions of class member variables / C++ standards violations

开放

#255 创建于 2023年4月18日

 (1 条评论) (2 个反应) (0 位负责人)C++ (21 个派生)auto 404
clean-upgood first issuehelp wanted

仓库指标

星标
 (36 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Within the context of singularity-eos we have different conventions for naming private variables which are members of classes. For nearly all of the analytic EOSs (for which I was mostly responsible) we use a leading underscore for private member variables. In such class scope, this is allowed under the standard, but only if the next character is neither an underscore nor a capital letter. This is part of C++ standards, and while it is likely to work without issue, it's technically reserved.

I propose changing all of the private member variables to trailing underscores, which is consistent with the tabular EOS implementations (both spiner and EOSPAC) and is not standards violating.

贡献者指南