lanl/MATAR

Naming kernels via macros.

开放

#85 创建于 2024年5月9日

 (1 条评论) (0 个反应) (0 位负责人)C++ (16 个派生)auto 404
documentationgood first issue

仓库指标

星标
 (33 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Kokkos lets us name kernels. We need to modify our macros to allow users to name the kernel. This will be super helpful for debugging, plus I think it will help us standardize the style of our macros. It would look something like this:

FOR_ALL( "SGH::get_force"
    elem_gid, 0, mesh.num_elems, {

        // do math here
});

This naming probably needs to be optional since it is optional in Kokkos, but I am not against forcing it. Me may also consider setting default names that are just the string representation of the macro name, which will at least narrow down which type of kernel launch is the bad actor.

A guide on creating macros with optional inputs is here: https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html

贡献者指南