langgenius/dify

[Chore/Refactor] not call the 'set' function of 'useState' directly in 'useEffect'

Open

#25,194 创建于 2025年9月5日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)TypeScript (141,412 star) (22,210 fork)batch import
good first issuerefactor

描述

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

not call the 'set' function of 'useState' directly in 'useEffect'

Motivation

keep logic simpler

Additional Context

https://react.dev/learn/you-might-not-need-an-effect

https://eslint-react.xyz/docs/rules/hooks-extra-no-direct-set-state-in-use-effect

贡献者指南

技术栈
reacttypescript
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React hooks basicsUnderstanding of useEffect and useState
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Review the React documentation at https://react.dev/learn/you might not need an effect and the ESLint rule at https://eslint react.xyz/docs/rules/hooks extra no direct set state in use effect. Identify all components in the codebase where setState is called directly inside a useEffect without condition. Refactor by removing the useEffect and computing state directly from props or previous state, or moving the setState call outside of useEffect if possible. Follow the patterns described in the linked resources.