lance-format/lance

Python: fix broken fragment APIs

Open

#1,006 创建于 2023年6月22日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)Rust (695 fork)github user discovery
A-pythongood first issue

仓库指标

Star
 (6,582 star)
PR 合并指标
 (平均合并 6天 1小时) (30 天内合并 219 个 PR)

描述

The APIs around getting and manipulating fragments are inconsistent with their return types.

In many cases, the type hint is wrong. For example, LanceFragment.create() claims to return LanceFragment (which would make sense), but instead returns _FragmentMetadata. Also odd that _FragmentMetadata has an underscore even though it is part of a public API.

We should refactor this to be consistent. Would also be nice to start enforcing the type hints with mypy.

贡献者指南