kubernetes/minikube

minikube should not start knfsd by default

开放

#3,143 创建于 2018年9月20日

 (8 条评论) (0 个反应) (0 位负责人)Go (5,222 个派生)batch import
area/guest-vmhelp wantedkind/featurepriority/awaiting-more-evidencer/2019q2

仓库指标

星标
 (31,799 个星标)
PR 合并指标
 (平均合并 12天 19小时) (30 天内合并 43 个 PR)

描述

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Please provide the following details:

Environment:

Minikube version (use minikube version): v0.28.2

  • OS (e.g. from /etc/os-release): Fedora 28
  • VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): kvm2
  • ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): v0.28.1

On startup, minikube starts up knfsd (via the nfs-server.service under systemd), even though it serves no exports. This makes it somewhat useless -- it should not start the nfs server unless it has something to serve:

● nfs-server.service - NFS server and services
   Loaded: loaded (/usr/lib/systemd/system/nfs-server.service; enabled; vendor preset: enabled)
   Active: inactive (dead) since Thu 2018-09-20 13:34:48 UTC; 7min ago
  Process: 2886 ExecStopPost=/usr/sbin/exportfs -f (code=exited, status=0/SUCCESS)
  Process: 2883 ExecStopPost=/usr/sbin/exportfs -au (code=exited, status=0/SUCCESS)
  Process: 2880 ExecStop=/usr/sbin/rpc.nfsd 0 (code=exited, status=0/SUCCESS)
 Main PID: 1781 (code=exited, status=0/SUCCESS)

Sep 20 12:06:54 minikube systemd[1]: Starting NFS server and services...
Sep 20 12:06:54 minikube systemd[1]: Started NFS server and services.
Sep 20 13:34:48 minikube systemd[1]: Stopping NFS server and services...
Sep 20 13:34:48 minikube systemd[1]: Stopped NFS server and services.

When constructing the ISO, could we add in a call to "systemctl disable nfs-server" to ensure that it's not started by default?

贡献者指南