kubernetes/minikube
move viper calls from packages into cmd to improve testability/resusablitily
开放
#21,670 创建于 2025年9月30日
help wantedkind/cleanuppriority/important-soon
仓库指标
- 星标
- (31,799 个星标)
- PR 合并指标
- (平均合并 12天 19小时) (30 天内合并 43 个 PR)
描述
packages inside minikube should not be calling viper to get a config, the viper (getting confg flags) should only be called form Cmd packages
this will help better testing and also avoid race conditions in Setting or Getting Flags in Parallel testing and Parallel usage of minikube and make minikube code more reusable and more testable
Originally posted by @medyagh in https://github.com/kubernetes/minikube/pull/21635#discussion_r2392461773