move viper calls from packages into cmd to improve testability/resusablitily · kubernetes/minikube#21670

(4 评论) (0 反应) (1 负责人)Go (31,799 star) (5,222 fork)batch import

help wantedkind/cleanuppriority/important-soon

描述

packages inside minikube should not be calling viper to get a config, the viper (getting confg flags) should only be called form Cmd packages

this will help better testing and also avoid race conditions in Setting or Getting Flags in Parallel testing and Parallel usage of minikube and make minikube code more reusable and more testable

Originally posted by @medyagh in https://github.com/kubernetes/minikube/pull/21635#discussion_r2392461773

贡献者指南

技术栈: go
领域: backenddeveloper experience
议题类型: refactor
难度: 3
预计时间: half day
活动状态: active
清晰度: clear
前置要求: Go programmingViper configuration libraryMinikube project structure
新手友好度: 60
研究方向: Examine the typical Viper configuration usage in Minikube's internal packages. Review the refactor example in PR #21635 and the discussion at https://github.com/kubernetes/minikube/pull/21635#discussion r2392461773. Identify all packages that directly call viper and plan to move those calls to the cmd layer. Ensure that configuration is passed as parameters to avoid global state.