kubernetes/kubernetes

Pod-level limits defaults not set when all containers have limits set and pod-level request is set

Open

#136,120 创建于 2026年1月9日

在 GitHub 查看
 (26 评论) (0 反应) (8 负责人)Go (122,268 star) (43,066 fork)batch import
help wantedkind/bugsig/nodetriage/accepted

描述

As per the requirements listed in the KEP, pod-level limits are set to aggregated container limits if all containers have limits set. Please check rows 10, 12 from the table in the KEP:

https://github.com/kubernetes/enhancements/blob/d57336d85b8673959916529873e71010a5d2a4fd/keps/sig-node/2837-pod-level-resource-spec/README.md?plain=1#L503-L507

The implementation is setting only pod-level requests defaults as per different scenarios. https://github.com/kubernetes/kubernetes/blob/98e6935d436d5068b3549e651e629f76ec96e3f7/pkg/apis/core/v1/defaults.go#L198

The bug fix involves adding the defaulting logic for pod-level limits such that when pod-level requests are set, and pod-level limits are unset and "all containers" have limits set then pod-level limits should be defaulted to aggregated container limits.

Instead of adding to the existing in defaults.go, it is recommended to limit this change to podStrategy#PrepareForCreate and podResizeStrategy#PrepareForUpdate and also guard the implementation behind a feature gate - PodLevelResourcesFixUpdateDefaulting

贡献者指南

技术栈
go
领域
backendinfrastructure
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingKubernetes resource defaultingFeature gatesPod resource spec
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
The bug is in the defaulting logic for pod level limits, as specified in the KEP at https://github.com/kubernetes/enhancements/blob/d57336d85b8673959916529873e71010a5d2a4fd/keps/sig node/2837 pod level resource spec/README.md. The fix should be added to podStrategy#PrepareForCreate and podResizeStrategy#PrepareForUpdate in the Kubernetes codebase, guarded by the feature gate PodLevelResourcesFixUpdateDefaulting. Review the issue comments for additional context on the implementation approach.