kubernetes/ingress-nginx

Support standard Forwarded header

Open

#10,263 创建于 2023年8月1日

在 GitHub 查看
 (15 评论) (9 反应) (2 负责人)Go (15,199 star) (7,888 fork)batch import
good first issuehelp wantedkind/featurepriority/backlogtriage/accepted

描述

As far as I can see the ingess controller currently just supports the "non-standard" X-Forwarded-* headers. It would be nice to support also the standard Forwarded header.

Use case

Keycloak has added support for the Forwarded header with version 21.0.0 and advices reverse-proxies to override this header.

贡献者指南

技术栈
go
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingHTTP header knowledgeKubernetes ingress basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests adding support for the standard Forwarded HTTP header alongside the existing X Forwarded * headers. Key files to investigate are likely in the internal/ingress/controller or pkg/ingress directories, where header handling is implemented. Review the current X Forwarded * logic and adapt it to handle the Forwarded header per RFC 7239. The Keycloak release notes provide context on why this is needed. Check if there are any linked PRs or comments about implementation approach.