kubernetes-sigs/cluster-api

Improve API around machine deletion strategy

开放

#7,021 创建于 2022年8月5日

 (8 条评论) (0 个反应) (0 位负责人)Go (1,532 个派生)auto 404
help wantedkind/api-changepriority/important-longtermtriage/accepted

仓库指标

星标
 (4,267 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

User Story

As a user, I would like to have a clean and simple API for configuring machine deletion strategy

Detailed Description

In recent version we expanded MachineSpec with fields allowing us to configure machine deletion strategy, nodeDeletionTimeout, nodeDrainTimeout and also volumeDetachTimeout (https://github.com/kubernetes-sigs/cluster-api/pull/6413); there are also annotations allowing to enable/disable one of the machine deletion steps, like e.g machine.cluster.x-k8s.io/exclude-node-draining

Last but not least we have more requests in the pipeline, like e.g. the request for adding support for DaemonSet eviction when draining nodes

This ticket is about discussing how to normalize the API surface for machine deletion strategy by (some ideas):

  • create a struct that groups all the flags related to this topic
  • introduce a more explicit way to enable/disable one of the machine deletion steps vs using annotations

/kind api-change /triage accepted

贡献者指南