kubernetes-sigs/cluster-api

How to surfacing runtime hook blocking cluster deletion in condition

开放

#6,807 创建于 2022年7月2日

 (10 条评论) (0 个反应) (0 位负责人)Go (1,532 个派生)auto 404
area/runtime-sdkhelp wantedkind/cleanuppriority/important-longtermtriage/accepted

仓库指标

星标
 (4,267 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Details:

This issue is to discuss how to surface that a cluster deletion is blocked when the BeforeClusterDelete hook blocks the deletion of a process with a blocking response.

We have 2 options:

  1. Use TopologyReconciled condition - Since only managed clusters are affected by BeforeClusterDelete hook we can use the TopologyReconciled condition to surface if a cluster deletion is blocked. Reason will be LifecycleHookBlocking. This will be consistent with how the other lifecycle hook blocking cases are surfaced.

  2. Use a separate condition - Since TopologyReconciled condition reflects if the underlying objects reflect the topology spec of the cluster using it for delete might be deviating from it purpose.

Some additional concerns:

  • How should the condition be updated after deletion is unblocked and the cluster is in the process of deleting the objects?
  • Which controller owns this condition?

/area runtime-sdk

贡献者指南