keystonejs/keystone-classic

Markdown field ignores `hiddenButtons` of `toolbarOptions` property

Open

#4,378 创建于 2017年7月2日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (14,656 star) (2,288 fork)batch import
bughelp wanted

描述

Expected behavior

toolbarOptions.hiddenButtons String - Comma separated list of buttons to hide.

{ type: Types.Markdown, toolbarOptions: { hiddenButtons: 'H1,H6,Code' } }

This should make H1, H2 and Code buttons to hide from the toolbar according to: http://keystonejs.com/docs/database/#fieldtypes-markdown

Actual/Current behavior

Buttons H1, H2 and Code are still in the toolbar, toolbarOptions.hiddenButtons does nothing.

Environment

Software Version
Keystone 4.0.0
Node 6.10.3, 7.10.0, 8.1.1

贡献者指南

技术栈
javascriptnodejs
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptFamiliarity with Keystone
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the Markdown field type's frontend component, likely located in the `fields/types/markdown` directory. Look for where `toolbarOptions` is used and how `hiddenButtons` is processed. The fix should ensure `hiddenButtons` is applied when initializing the toolbar.
Markdown field ignores `hiddenButtons` of `toolbarOptions` property · keystonejs/keystone-classic#4378 | Good First Issue