keystonejs/keystone-classic

4.0.0: Twig cache still set to true in developpment

Open

#4,268 创建于 2017年5月7日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (14,656 star) (2,288 fork)batch import
bughelp wanted

描述

When passing env to developpment, twig cache isn't set to false, I have to set it manually in node_modules/twig/twig.js. In fact whatever the setting of env and cache view, the twig cache is always set to true.

Software Version
Keystone 4.0.0
Node v7.3.0

贡献者指南

技术栈
nodejs
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic Node.js knowledgeunderstanding of environment variables
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue states that Twig cache remains true in development mode regardless of env setting. Investigate how Keystone 4.0.0 reads environment configuration, particularly the `env` parameter and any Twig cache options. Look at the relevant files like `keystone.js` or the module loading of twig. Check if there's a missing condition to set `cache: false` when `env` is set to 'development'. Examine the current release's source code for how Twig is initialized. The fix likely involves ensuring the cache option is properly passed based on the environment.