kazupon/vue-i18n

Memory Leak SSR

Open

#589 创建于 2019年5月27日

在 GitHub 查看
 (15 评论) (1 反应) (0 负责人)JavaScript (7,181 star) (886 fork)batch import
Status: PR WelcomeType: Bughelp wanted

描述

vue & vue-i18n version

vue-i18n v8.11.2

Reproduction Link

any SSR usage

Question

In line https://github.com/kazupon/vue-i18n/blob/master/src/mixin.js#L58 a new object is created server-side because we are in beforeCreate. This is necessary to get the languages rendered server-side as far as I can see but at the same time it generates a memory leak because the destructor is not called by SSR. Do you have any ideas how to overcome this issue?

贡献者指南

技术栈
vuejavascriptnodejs
领域
backendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Vue.js basicsSSR understandingMemory leak awareness
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the mixin.js file at line 58 (https://github.com/kazupon/vue i18n/blob/master/src/mixin.js#L58). Look into how the 'beforeCreate' hook creates new objects server side causing memory leaks, as the destructor is not called. Propose a solution that either avoids creating these objects during SSR or ensures proper cleanup. Consider using a WeakMap or a server side cache that gets cleared after rendering.