kaldi-asr/kaldi

Fix registering of CuAllocatorOptions

Open

#2,929 创建于 2018年12月21日

在 GitHub 查看
 (6 评论) (0 反应) (1 负责人)Shell (15,392 star) (5,359 fork)batch import
bughelp wantedstale

描述

Currently it seems we register the global options but don't call the SetOptions() function. There is no need for the global options-class variable, we can use a local one in each binary that registers the options. @desh2608 can you please do this? Ask one of the other students if you don't know how.

贡献者指南

技术栈
cppshell
领域
backendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++Kaldi framework
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is about fixing the registration of CuAllocatorOptions. The current code registers global options but does not call SetOptions(). The fix is to remove the global variable and use a local CuAllocatorOptions instance in each binary that registers options, then call SetOptions(). The relevant code is likely in the Kaldi source where CuAllocatorOptions is defined. Check comments from maintainer @desh2608 for further guidance. No linked PRs exist.
Fix registering of CuAllocatorOptions · kaldi-asr/kaldi#2929 | Good First Issue