jupyterhub/repo2docker

Always convert line endings in `postBuild` to unix

Open

#263 创建于 2018年3月15日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (1,544 star) (358 fork)batch import
enhancementgood first issuehacktoberfesthelp wanted

描述

We should filter/convert the line endings in postBuild as that seems to cause problems (see https://github.com/jupyter/repo2docker/issues/237#issuecomment-373446647)

Is there a docker option to have it convert line endings on COPY or do we have to convert it before copying or add a tool like dos2unix to the container?

贡献者指南

技术栈
pythondocker
领域
backenddevops
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Knowledge of DockerLine ending concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the linked comment in issue #237 to understand the exact problem. Check if Docker has a line ending conversion option during COPY. If not, explore converting the postBuild file before copying it into the container or adding a tool like dos2unix. The solution should ensure Unix line endings are used consistently.
Always convert line endings in `postBuild` to unix · jupyterhub/repo2docker#263 | Good First Issue