jsx-eslint/eslint-plugin-react

no-direct-mutation-state on references

Open

#747 创建于 2016年8月7日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

Currently no-direct-mutation-state doesn't seem to support hunting down (even simple cases) where a reference to this.state is being used. Luckily I caught my co-workers bug while doing code review but it would be pretty sweet if the rule could detect this case too.

const { product } = this.state;
product.name = name;

I've never written an eslint rule before so I have no clue if this is even possible, if it is, please let me know and I might give it a stab when I have some more free time.

贡献者指南

技术栈
javascriptreact
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of ESLint rulesAST traversal
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the existing rule implementation in src/rules/no direct mutation state.js to understand how it currently detects direct mutations of this.state. Adapt the logic to track references to state properties, e.g., when const { product } = this.state; is followed by product.name = name;. Consider using ESLint's no param reassign rule as inspiration. Check the issue comments for any suggestions and test with the provided example.