jsx-eslint/eslint-plugin-react

[Bug]: react/jsx-no-leaked-render reports error on boolean values and tries to convert them

Open

#3,908 创建于 2025年3月21日

在 GitHub 查看
 (2 评论) (5 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wantedtypescript

描述

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Using following setup:

'react/jsx-no-leaked-render': ['error', { validStrategies: ['ternary', 'coerce'] }]

Image

The code reports error even though emptyCollection is already boolean value. I understand that the plugin does not take into account actual types that TS provides.

Running lint command reports an issue unless I convert the code to this 👇

Image

Is there a way to prevent this from being "fixed" since it's already a boolean value?

Expected Behavior

eslint-plugin-react version

v7.37.4

eslint version

v9.18.0

node version

v22.13.0

贡献者指南

技术栈
javascriptreact
领域
frontendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentReact JSXAST understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the rule implementation at `lib/rules/jsx no leaked render.js`. Review the test file for this rule (likely `tests/lib/rules/jsx no leaked render.js`) to understand current test cases. The core issue is that the rule incorrectly flags boolean variables when using the ternary or coerce strategy. Determine if the rule should rely on TypeScript type annotations (using `@typescript eslint/parser`) or if a simpler heuristic (e.g., checking that the expression is a boolean literal or `typeof x === 'boolean'`) can be applied. Check the comments in issue #3908 for any maintainer suggestions.