jsx-eslint/eslint-plugin-react

require-default-props: Allow disabling "must have default value" warning but keeping "forbid defaults for required props"

Open

#3,660 创建于 2023年12月1日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

Right now there doesn't seem to be a way to do this.

  • Having to specify a null/undefined default for a prop where you're perfectly fine with it being undefined when not specified feels a bit pointless
  • This is made worse for a prop where you want to allow null, because a required prop will fail runtime proptypes validation when its value is null (even if it's explicitly set to null

So I'd like to just ditch the part of having to specify default for optional props, but still prohibit setting defaults for required ones.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with eslint plugin reactUnderstanding of React PropTypes
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the current implementation of the require default props rule in the eslint plugin react codebase (likely src/rules/require default props.js). The goal is to add a new option that disables the warning for missing default values on optional props while retaining the check that forbids defaults on required props. Review existing test files (e.g., tests/rules/require default props.js) to understand the expected behavior and ensure backward compatibility. Consider the configuration schema and how the new option can be integrated with existing rule options.