jsx-eslint/eslint-plugin-react

[Bug]: `react/prop-types` false positive when component is a value of capitalized property in class

Open

#3,534 创建于 2023年2月21日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Weird error: image

import React from 'react';

class SomeComponent {
	column = {
		Cell: ({ original }: { original: string }) => <span>{original === 'bla' ? 'bla' : 'bla'}</span>,
	};
}

error    'original' is missing in props validation  react/prop-types

eslint myfile.tsx

Expected Behavior

Not to throw error

When I change Cell to cell - the error is gone. When I avoid using destructuring - the error is also gone.

eslint-plugin-react version

v7.32.2

eslint version

v8.34.0

node version

v18.14.1

贡献者指南

技术栈
javascripttypescriptreact
领域
frontendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin architectureReact prop types ruleTypeScript basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Start by examining the `react/prop types` rule implementation in `lib/rules/prop types.js`. Look for how the rule identifies React components and validates props. The bug occurs when a component is assigned to a capitalized property (e.g., `Cell`) in a class instance, causing a false positive. Investigate the logic that determines whether a variable is a component vs. a regular prop. Check the issue comments for any maintainer hints or related PRs. Focus on the expression handler and see if the capitalization triggers an incorrect assumption that the value is a component.