jsx-eslint/eslint-plugin-react

react/prop-types false positive “is missing in props validation” for extended component types

Open

#3,159 创建于 2021年12月15日

在 GitHub 查看
 (2 评论) (4 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
help wantedtypescript

描述

I’m building a component with antd-style subcomponent access. I.e. I want to be able to do <Columns><Columns.Block/></Columns>.

I made two attempts, both of which complained about “… is missing in props validation” once I replaced a bare FC<…> with something else:

By extending FC<…>:

const Block: FC<…> = (…) => …

export interface ColumnProps { … }
export interface ColumnsComponent extends FC<ColumnsProps> {
  Block: typeof Block
}
const Columns: ColumnsComponent = (…) => …
Columns.Block = Block

and inline:

const Block: FC<…> = (…) => …

export interface ColumnProps { … }
const Columns: FC<ColumnsProps> & { Block: typeof Block } = (…) => …
Columns.Block = Block

贡献者指南

技术栈
javascripttypescriptreact
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin development basicsReact prop types ruleTypeScript type extension patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the prop types rule source in `lib/rules/prop types.js`. Understand how it currently extracts prop types from type annotations. The false positive occurs when the component type is an extension of FC (e.g., FC<Props> & { Block: typeof Block }). Look at the rule's handling of intersection types. Review any existing tests for similar patterns. Consider adding a test case with the provided code and adjusting the rule logic to correctly handle extended component interfaces.
react/prop-types false positive “is missing in props validation” for extended component types · jsx-eslint/eslint-plugin-react#3159 | Good First Issue