jsx-eslint/eslint-plugin-react

Ignore nested components in no-multi-comp

Open

#2,842 创建于 2020年10月24日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
help wanted

描述

I don’t think react/no-multi-comp should trigger on nested components or should have an option to disable it. A practical example:

import { FormattedMessage } from 'react-intl';

export function App() {
  return (
    <FormattedMessage
      values={{
        link:
          // The next line triggers react/no-multi-comp
          (text: string) => <a>{text}</a>,
      }}
    />
  );
}

I suggest to add an option ignoreNested which ignores any components that aren’t declared as part of the Program node body.

贡献者指南

技术栈
javascriptreact
领域
frontendtooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentAST concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
To implement the request, modify the rule in src/rules/no multi comp.js to detect whether a component is declared inside another component (i.e., not at the Program body level). Add an option named "ignoreNested" (boolean) that skips components whose parent node is not the Program. Ensure the option is documented in the rule's schema and README. Test with the given example to confirm nested components are ignored.