jsx-eslint/eslint-plugin-react

Don't warn about react/jsx-no-target-blank when referrerPolicy is used

Open

#2,398 创建于 2019年9月2日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

We have in our code:

<a rel="noopener" referrerPolicy="no-referrer" target="_blank" href={fooURL}>foo</a>

But react/jsx-no-target-blank is complaining about it with:

 Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener  react/jsx-no-target-blank

Isn't it the same to have rel="noopener" and referrerPolicy="no-referrer" as having rel="noopener noreferrer"?

eslint-plugin-react@7.14.3

贡献者指南

技术栈
javascriptreact
领域
securitydeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with ESLint plugin structureUnderstanding of React JSXKnowledge of security implications of target=' blank'
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the implementation of the jsx no target blank rule in lib/rules/jsx no target blank.js. Examine the existing logic that checks for rel attributes and consider how referrerPolicy attribute should be treated as equivalent to rel='noopener noreferrer'. Check the test file for existing test cases and add new ones. Look at comments in the issue for any suggested approach.