jsx-eslint/eslint-plugin-react

warn when using setState in constructor

Open

#2,371 创建于 2019年8月5日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
acceptedhelp wantednew rule

描述

Obviously it could have been used by functions called from the constructor, but using setState in constructor is always an issue in react and causes a warning in debug mode.

贡献者指南

技术栈
javascriptreact
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React basicsESLint rule creation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests a warning when setState is called directly inside a constructor. Research existing rules in the eslint plugin react repo, such as no unused state, for implementation patterns. The new rule should traverse AST nodes to identify constructors (e.g., ClassBody with MethodDefinition kind 'constructor') and detect CallExpression to setState. Consider also tracking calls to functions invoked from the constructor. Review the 3 comments on the issue for additional context or pitfalls. Then implement the rule in a new file under rules/ and add tests.