jsx-eslint/eslint-plugin-react

prefer-stateless-function should not check a .d.ts for a Stateful Component

Open

#2,296 创建于 2019年5月31日

在 GitHub 查看
 (3 评论) (2 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wantedtypescript

描述

Imagine that we have a stateful react component and is about to creating a declaration file d.ts for the .js/.jsx file.

declare class StateCom extends React.Component<Props> {}
export default StateCom;

and error/warning occurs that: Component should be written as a pure function eslint(react/prefer-stateless-function)

How can we handle this since the component is a truly Component with state instead of a functional component?

贡献者指南

技术栈
javascripttypescriptreact
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of ESLint plugin developmentunderstanding of TypeScript declaration files
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the rule implementation in `lib/rules/prefer stateless function.js`. Look for how the rule checks file extensions or AST node types to determine if a component is stateful. The fix should likely skip `.d.ts` files or skip class declarations within them. Check existing tests in `tests/lib/rules/prefer stateless function.js` for patterns. Consider adding a test case with a `.d.ts` file. Review any comments in the issue for maintainer input.