jsx-eslint/eslint-plugin-react

[ESLint v5.9.0] Fix types

Open

#2,039 创建于 2018年11月9日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

A new option was added to ESLint. Reference: https://eslint.org/blog/2018/11/eslint-v5.9.0-released#the-fix-type-option

Should we start supporting this? If so, looks like "layout" is pretty obvious, but "problem" vs "suggestion" could be harder to tell. Or should we just set all recommended non-layout rules to "problem"?

贡献者指南

技术栈
javascriptreact
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ESLint plugin basicsunderstanding of ESLint fix types
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the ESLint v5.9.0 release notes for the fix type option (https://eslint.org/blog/2018/11/eslint v5.9.0 released#the fix type option). Examine existing rules in the plugin (e.g., in src/rules/) to understand current meta.fixable values. Determine a strategy for categorizing rules into 'layout', 'problem', or 'suggestion' based on rule intent. Decide whether to set all recommended non layout rules to 'problem' or require per rule analysis. Implement changes to each rule's meta.fixable property and add corresponding test updates.