jsx-eslint/eslint-plugin-react

react/prefer-stateless-function works different than described in docs

Open

#1,901 创建于 2018年7月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

For the react/prefer-stateless-function rule the docs for ignorePureComponents option states:

When true the rule will ignore Components extending from React.PureComponent that use this.props or this.context.

Actually it also ignore every PureComponent that use not only props or context, but ignores every component that use this. If this is not intended I prepared a fix (GH-1902), otherwise it makes sense to update the docs.

贡献者指南

技术栈
javascriptreact
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ESLint rule developmentReact component patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the rule implementation in lib/rules/prefer stateless function.js and its test suite to confirm the behavior discrepancy. Check the linked PR (GH 1902) for a proposed code fix and ensure it aligns with the intended rule logic. Evaluate whether updating the documentation to match current behavior is simpler than fixing the code. Since the issue is old and has no recent activity, consider reaching out to maintainers for guidance on the preferred resolution path.