jsx-eslint/eslint-plugin-react

New rule: identify missing PropType definition

Open

#1,887 创建于 2018年7月18日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
help wantednew rule

描述

I accidentally forgot to add the PropTypes assignment to a prop and this was not picked up by eslint:

const propTypes = {
    actions: {
        something: PropTypes.func.isRequired,
    }.isRequired,
};

should have been

const propTypes = {
    actions: PropTypes.shape({
        something: PropTypes.func.isRequired,
    }).isRequired,
};

贡献者指南

技术栈
javascriptreact
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentAST parsingReact
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests a new ESLint rule to detect missing PropTypes.shape wrapper around nested prop definitions. The example shows a case where an object literal is directly assigned as a value to a prop instead of wrapping it with PropTypes.shape. To implement this, study the existing rules in the eslint plugin react repository, particularly those related to PropTypes validation. The new rule should parse the AST to identify PropTypes assignments and verify that nested objects are wrapped with PropTypes.shape. It should also include proper test cases and documentation.