jsx-eslint/eslint-plugin-react

Detect uninitialized states and statefulness

Open

#1,778 创建于 2018年4月30日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
help wantednew rulequestion

描述

First things first, thank you for making this great plugin. 🙌🏻I'm hopeful that I will be able to contribute to this project. Maybe you can tell me if my two requests below make sense. Or maybe there are some rules which I do the job that I haven't discovered yet.

  • PureComponent detection works well but not the other way around: there are no errors thrown for using setState in a component declared as extends React.PureComponent.
  • In React 16.3, it eslint should warn if we have uninitialized state in a stateful component.

贡献者指南

技术栈
javascriptreact
领域
frontenddeveloper experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic ReactESLint plugin structureNode.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The contributor should examine existing rules like 'no set state in component' and 'no unused state' to understand patterns. Look at the component detection utilities in eslint plugin react's source code (likely in 'lib/util/'). Investigate React 16.3's constructor requirement for initializing state. Review the issue comments for any maintainer hints or related PRs.