jsx-eslint/eslint-plugin-react

New Rule: Prevent boolean values for unknown props

Open

#1,695 创建于 2018年2月15日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wantedreact 16

描述

React 16 does not ignore Boolean values for unknown props anymore.

So while this code "worked" in react 15:

<div onClick={!disabled && onClick}/>

It would try to assing false to the DOM elements onClick handler when disabled === true (which would be ignored by the browser).

React 16 will print an error message in the console though.

How about a rule that does not allow boolean results for unknown props?

See https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html#changes-in-detail "Non-boolean attributes with boolean values"

贡献者指南

技术栈
javascriptreactnodejs
领域
frontendtooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React JSXESLint rule development
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Implement a new ESLint rule that flags boolean values assigned to non boolean DOM props. Study the existing rule 'no unknown property' in lib/rules/ for pattern. The rule should check JSX attributes where the value is a boolean and the prop name is not a known boolean attribute. Test cases should be added in tests/lib/rules/. Reference the React 16 blog post for the behavior change. Check comments in issue #1695 for any additional guidance.