jsx-eslint/eslint-plugin-react

no-array-index-key not triggered when spreading props

Open

#1,625 创建于 2017年12月24日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

There's no warning or error when doing something like this:

people.map(({ name, email }, key) => {
  const props = {
    key,
    name,
    email,
  };

  return <Person {...props} />;
});

I realize this is a bit of an edge case, but maybe we can find a way to catch these uses as well.

贡献者指南

技术栈
javascriptreact
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with ESLint plugin structureUnderstanding of AST traversal
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue is about the `no array index key` rule not triggering when the key is spread via props. To fix this, examine the rule implementation in `lib/rules/no array index key.js`. The rule currently checks for `key` prop directly on JSX elements but does not detect `{...props}` spreading. Investigate how other rules handle prop spreading, and consider adding a helper to look for `key` in object expressions used in JSX spread attributes. Also check the rule's test file (`tests/lib/rules/no array index key.js`) for existing test cases and add new ones covering spread scenarios.