jsx-eslint/eslint-plugin-react

Bug: jsx-closing-bracket-location autofix removes whitespace character

Open

#1,501 创建于 2017年10月26日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

<div>
  foo </div>

Renders a space in HTML: <div>foo </div>

After fix is applied, it becomes:

<div>
  foo 
</div>

Note that there IS a space after foo in the output, however this space will typically be linted off by no-trailing-spaces rule, and even if it's not linted out of your source code, it will be ignored by React's JSX parser, meaning the output HTML will be <div>foo</div> 100% of the time.

tl;dr

<div>foo </div> becomes <div>foo</div>

贡献者指南

技术栈
javascriptreact
领域
frontenddeveloper experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentReact JSX
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the `jsx closing bracket location` rule's autofix code. The bug is that when moving the closing bracket to a new line, a trailing space is lost. The fix should preserve the space character before the closing bracket. Look at the rule's implementation in the repo, likely in `lib/rules/jsx closing bracket location.js`. Write a test case matching the issue example and ensure the autofix keeps the space intact.
Bug: jsx-closing-bracket-location autofix removes whitespace character · jsx-eslint/eslint-plugin-react#1501 | Good First Issue