jsx-eslint/eslint-plugin-react

react/no-direct-mutation-state doesn't catch all cases

Open

#1,418 创建于 2017年9月8日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
help wanted

描述

  const { model } = this.state;
  model.rating = rate;

In this case eslint won't show any errors.

贡献者指南

技术栈
javascriptreact
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of ESLint rulesUnderstanding of React's state mutation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
42
研究方向
The issue reports that the rule `react/no direct mutation state` fails to flag cases where a nested property of `this.state` is mutated indirectly, e.g., `const { model } = this.state; model.rating = rate;`. To fix this, examine the existing rule implementation in `lib/rules/no direct mutation state.js` and modify it to detect assignments to properties of objects retrieved from `this.state`. A possible approach is to track when a variable is assigned a value from `this.state` and then flag any subsequent member assignments on that variable. See issue #1418 and the rule's source code for details.