jsx-eslint/eslint-plugin-react

Rule idea: no-mutation-props

Open

#1,113 创建于 2017年3月14日

在 GitHub 查看
 (6 评论) (8 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
help wantednew rulequestion

描述

A component is never meant to modify its own props (https://facebook.github.io/react/docs/components-and-props.html#props-are-read-only).

I suggest we had a no-mutation-props rule to check for mutations of a components own props. It looks like we could likely copy the logic used in no-direct-mutation-state.js.

贡献者指南

技术栈
javascriptreactnodejs
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentReact props immutabilityAST manipulation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Look at the existing rule no direct mutation state.js in the same repository (lib/rules/no direct mutation state.js) to understand the logic for detecting mutations. Adapt it to detect mutations of props instead of state. Consider edge cases like nested props and object spread. Review the React documentation link provided in the issue. Check the issue comments for any additional discussion on implementation details or scope.
Rule idea: no-mutation-props · jsx-eslint/eslint-plugin-react#1113 | Good First Issue