jsx-eslint/eslint-plugin-react

react/require-optimization warns when using PureRenderMixin.shouldComponentUpdate

Open

#1,019 创建于 2017年1月11日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

react/require-optimization reports the following as incorrect even though it follows Facebook's documentation for using PureRenderMixin with ES6 classes (link):

export class MyComponent extends React.Component {
    constructor(props) {
        super(props);
        this.shouldComponentUpdate = PureRenderMixin.shouldComponentUpdate.bind(this);
    }
}

I can try submitting a fix if you agree that this is actually a bug

贡献者指南

技术栈
javascriptreact
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptReactESLint pluginsPureRenderMixin
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the rule implementation for `react/require optimization` in the eslint plugin react repository. Look for the code that checks `shouldComponentUpdate` and determine why it flags cases where the method is assigned in the constructor via `PureRenderMixin.shouldComponentUpdate.bind(this)`. Consider modifying the rule to allow this pattern as per the Facebook documentation referenced in the issue.
react/require-optimization warns when using PureRenderMixin.shouldComponentUpdate · jsx-eslint/eslint-plugin-react#1019 | Good First Issue