josdejong/mathjs

null/undefined treated as valid only for left side of comparison operators

Open

#1,391 创建于 2019年1月31日

在 GitHub 查看
 (11 评论) (0 反应) (0 负责人)JavaScript (13,832 star) (1,298 fork)batch import
bughelp wanted

描述

Using mathjs@5.4.1

When the null value is on the right side, the correct error is thrown (actual: null):

> require('mathjs').eval('1 > null')
TypeError: Unexpected type of argument in function larger (expected: number or Array or DenseMatrix or SparseMatrix or string or boolean or Matrix or BigNumber or Complex or Fraction, actual: null, index: 1)

However, when the null value is on the left side, the error mistakenly identifies the right side as the source of the problem (actual: number):

> require('mathjs').eval('null > 1')
TypeError: Unexpected type of argument in function larger (expected: Array or DenseMatrix or SparseMatrix or Matrix, actual: number, index: 1)

贡献者指南

技术栈
javascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptfamiliarity with mathjs error handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Investigate the comparison operator functions in mathjs, specifically the error handling when left and right operands are of different types. The issue reports that null on the left side causes an incorrect error message indicating the right side is wrong. Look at the function 'larger' and similar comparison functions to see how they validate types and generate error messages. The fix likely involves ensuring that both arguments are checked symmetrically.
null/undefined treated as valid only for left side of comparison operators · josdejong/mathjs#1391 | Good First Issue